Will

@Armouredivision DMing you a test version if you could see if anything is still not working as it should.

Ah, I see in the source why it works for theirs. They are using the native to create the weapon object and passing the current weapon model hash as the custom model hash. This is how I discovered I would need to do it. Currently I create the weapon object by creating a new Weapon via RPH but that does not support a custom model hash. Maybe I can convince LMS to add this...

I think SHVDN has better weapon component methods than RPH. I imagine the issue with the attachments in that mod is the order in which they are applying them. That's the issue with the CAMO type finishes in my mod.

The issue is much more complicated than I expected. I'm guessing at some point Rockstar changed how adding the luxury finishes to weapons works. I've spent the last few hours breaking things and confusing myself. This may be something that gets fixed or may not be. I will at least try to get the other forms of finishes working - I was able to do that before needing to ctrl-z all of my changes. Those are not as complicated as the luxury finishes. The components with VARMOD in the name are the luxury finishes and require changing the actual weapon model now (in a weird way), but the ones with CAMO are easy to include and get working (some may already be working).

Thanks. It seems the component hashes have changed and additional ones have been added. I'll see if I can get this fixed.

I don't log the version anywhere in the log file so I'm not sure how log reading bots would know whether it's up to date or not anyway. I updated the version number in any case.

The 37707 is an automatic revision number that is calculated by the number of seconds since midnight divided by 2 at the time of build. I didn't think it necessary to include this on the file page.

I think I figured it out. When swapping weapons while aiming, the game does not seem to always register the task for swapping weapons, or there's some timing issue between me checking for it and the game running it. My code does not execute while the character is actively swapping weapons in order to prevent timing issues with the weapon change. Because the task isn't being detected, the weapon swap is effectively taking place simultaneously with my checks, and things get wonky. It took me multiple iterations to figure out the best way to fix this, but ultimately I realized that when this happens, the current EquippedWeaponObject becomes invalid in the middle of one of my while loops, so just breaking that loop when it does seems to fix the issue. I'll release an update shortly. For now, thanks for reading, and thanks for reporting the issue.

I wasn't aware of this issue. In my quick test, it seems to only happen if you quickly swap between an unaccepted weapon and an accepted weapon after aiming. If you aim for a few seconds, it seems to work as intended. It also seems fine if you swap between two accepted weapons. Can you confirm you have the same behavior? I'll try to find time to investigate further and see if I can narrow down the problem. Thanks for letting me know.

I think the most appropriate thing in that case may be to post a link to the fork (similar to how we have a link to ScriptHookV), but we would need to discuss internally.