Hi everyone

 

I want to run a function (void) every 10s after going on duty. I'm pretty new to C# so I have no idea how I would do that. I was looking for something similar to setInterval() in JavaScript. After looking online, I found a solution with Timer but that seems to either crash GTA or throw an error. 

 

private static void Functions_OnOnDutyStateChanged(bool OnDuty) {
	if (OnDuty) {
      
		doStuff(); // run this every ten seconds
      
    }
}

 

Edit: 

I found this: https://learn.microsoft.com/en-us/dotnet/api/system.timers.timer.interval?view=netframework-4.7.1 and tried it but GTA will crash:

private static Timer timer;
private static void Functions_OnOnDutyStateChanged(bool OnDuty) {
	if (OnDuty) {

		timer = new Timer();

		timer.Interval = 10000;

		timer.Elapsed += Timer_Elapsed;

		timer.Enabled = true;

	}
}
private static void Timer_Elapsed(object sender, ElapsedEventArgs e) {
	doStuff();
}

 

Thanks to anyone who took the time to read this

Edited September 28, 20232 yr by HeyPalu

Alright turns out this actually does work. My function just seems a little too much to be run multiple times or at least only running a game log won't crash GTA. 

21 hours ago, HeyPalu said:

I found this: https://learn.microsoft.com/en-us/dotnet/api/system.timers.timer.interval?view=netframework-4.7.1 and tried it but GTA will crash:

private static Timer timer;
private static void Functions_OnOnDutyStateChanged(bool OnDuty) {
	if (OnDuty) {

		timer = new Timer();

		timer.Interval = 10000;

		timer.Elapsed += Timer_Elapsed;

		timer.Enabled = true;

	}
}
private static void Timer_Elapsed(object sender, ElapsedEventArgs e) {
	doStuff();
}

 

@HeyPalu It is likely crashing because the timer callback does not happen on the same thread as the game's script. If you do not want to create your own timer class, you could simply have a variable that keeps the game time you started something and then compares it to the current game time + interval.

1 hour ago, LMS said:

you could simply have a variable that keeps the game time you started something and then compares it to the current game time + interva

Alright thanks for your response. I know what you mean but I do not know how to write that in C#. I would love to implement it into my plugin though; So, if you have the time, I would really appreciate it if you could show me a code example or tell me where I could find one. 

@LMS can you make that a bit more understading for us?

 

I submitted a pull request to the github repo, this should help out with the crashes & such caused by the Timers.

While I do not have time to go into depth explaining what timers does and such, what I added should at least solve somewhat the issue of the crashing/freezing of GTA, I included a link in the commit description showing RagePluginHook documentation that maybe might explain what I am trying to say better instead.

@timnboys thank you so much. I'll try it out tomorrow

Solution

 

Thanks to @Echooo I finally got it working 

GameFiber IntervalFiber = GameFiber.StartNew(Interval);

private static void Interval() {
  // CurrentlyOnDuty is updated in the duty change handler
    while (CurrentlyOnDuty) {
        doStuff();
        GameFiber.Wait(30000);
    }
}